Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

Gimleux
Copy link
Member

@Gimleux Gimleux commented Dec 5, 2020

No description provided.

@Gimleux Gimleux requested a review from open-schnick December 5, 2020 18:05
@Gimleux Gimleux self-assigned this Dec 5, 2020
Copy link
Member

@open-schnick open-schnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean your switch cases doe not mean anything if you dont have the right value.

@open-schnick
Copy link
Member

open-schnick commented Dec 6, 2020

i mean the path contains the fully qualified path to the folder. you have several folders without case and several with a wrong path.

@open-schnick
Copy link
Member

Fixed it for you.

@open-schnick
Copy link
Member

@Gimleux look at it again and merge it if you are happy.

@Gimleux Gimleux merged commit 701f06d into master Dec 6, 2020
@Gimleux Gimleux deleted the feature/addingMoreDummyData branch December 6, 2020 11:38
Gimleux added a commit that referenced this pull request May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants