This repository was archived by the owner on Apr 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/FF-218 #53
Merged
Merged
Feature/FF-218 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/de/filefighter/rest/configuration/PrepareDataBase.java # src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java # src/main/java/de/filefighter/rest/domain/user/business/UserAuthorizationService.java # src/main/java/de/filefighter/rest/domain/user/business/UserBusinessService.java
11h and still no unit tests..... |
Ok i changed alot @qvalentin we need to change alot in the frontend too. |
|
qvalentin
reviewed
Dec 19, 2020
src/main/java/de/filefighter/rest/configuration/CorsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/user/business/UserBusinessService.java
Show resolved
Hide resolved
|
… into feature/FF-218
qvalentin
reviewed
Dec 20, 2020
src/main/java/de/filefighter/rest/configuration/CorsConfig.java
Outdated
Show resolved
Hide resolved
Now the only Thing left todo is to implement the changes in the frontend. @qvalentin @Gimleux |
qvalentin
approved these changes
Dec 20, 2020
open-schnick
commented
Dec 21, 2020
…ded stage spring profile
Gimleux
pushed a commit
that referenced
this pull request
May 20, 2021
* WIP FF-218 Write Code for ShowContents * Added UserBusinessService.userWithUsernameDoesExist * Renamed dto to DTO, removed PermissionSets from FileSystemItems. * FF-218 Added main functions. * Added defaults to builder classes. * FF-218 Added FileSystemBusinessService.userIsAllowedToSeeFileSystemEntity * commented out tests. * Works but i need to rework the dto structure * FF-218 Should work now. Needs testing. * Fixed Merge Import Problems * Fixed Merge Annotation Problem * Added missing @DaTa * Added missing @builder * Added missing DummyFile. * Added Cors for local dev purposes only. * Cleanup * Added more @Builder.default * Fixed Test, Wrote UnitTests (1/2) * Fixed Test, Wrote UnitTests (2/2) * Added createBasicFilesForNewUser * Updated Sonar Hostname * Implemented Changes requested by @qvalentin * Ignored Stupid CodeSmells * Added TotalFileSize To SystemHealth * Sonar needs to access over https * added import of ssl cert for reaching sonar * also trigger workflow when workflow config is changed * bad echo? * changed passowrd * changed passowrd * use default password * why did i take the password 'changeit' literally * debug * remove debug * added SONAR_SCANNER_OPTS * ups wrong repo * trying https * everything https * made it use http for the links * added test image * undo changes * Refactored Steps and Feature File. * no https for badges images * Added same scenario but with groups * Added Steps, Fixed the feature. * Small fixes. * Fixed Tests * Bumped Up Version to -> 0.0.6 * added .run to gitingore * Revert Changes, set default profile to "test" while running tests, added stage spring profile Co-authored-by: qvalentin <valentin.theodor@web.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff todo: