FF-251 Delete FileSystemItem API Endpoint #62

open-schnick · 2020-12-26T16:01:36Z

No description provided.

open-schnick · 2020-12-26T16:10:59Z

As you can see, i changed the exceptions quite a lot.

src/test/java/de/filefighter/rest/cucumber/ViewFolderContentsSteps.java

open-schnick · 2020-12-27T10:55:37Z

lovely @qvalentin

open-schnick · 2020-12-29T18:45:10Z

still working on it. will be ugly to implement, let me know if you have a better implementation

qvalentin · 2020-12-29T18:49:14Z

How should the FE behave when the user selects multiple files and wants to delete them?

send all requests at the same time
send them one by one (showing a progress bar)
have another endpoint that accepts an array of fileIDs to delete

What would be the best for the database performance and also for the filehandler?

open-schnick · 2020-12-29T19:05:19Z

How should the FE behave when the user selects multiple files and wants to delete them?

send all requests at the same time

send them one by one (showing a progress bar)

have another endpoint that accepts an array of fileIDs to delete

What would be the best for the database performance and also for the filehandler?

i think it does not really matter. I personally like opt 2 most.

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java

qvalentin

nice nice

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java

src/test/java/de/filefighter/rest/cucumber/CommonCucumberSteps.java

src/test/java/de/filefighter/rest/cucumber/ViewFolderContentsSteps.java

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java

# Conflicts: # src/main/java/de/filefighter/rest/domain/filesystem/data/persistence/FileSystemEntity.java # src/test/java/de/filefighter/rest/domain/user/business/UserBusinessServiceUnitTest.java

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java

src/test/resources/ViewFolderContents.feature

src/test/resources/deleteFileSystemItems.feature

@qvalentin

* FF-251 Added basic structure and exception + handler. * Cleanup. Reworked custom Exceptions. * Cleanup. Implemented Change in UnitTests. * Cleanup. Implemented necessary changes to cucumber steps * added the .feature file for deleting * FileSystemItem now includes the User * fixed copy pesto, added step function * removed the empty lines * minor fixes, recusive scenarion for permissions * Cleanup. Refactored getContentsOfFolder. * Commented out feature. * Implemented TODO, updated tests. * WIP. basic structure, added wip comments * WIP. added checks for invisible entities. * WIP. started implementing. Added more comments. * Fixed Tests. * FF-251 finished adding logic. * Added UnitTests (1/2) * added some comments to understand the recursion * Fixing, refactoring. * Added UnitTests (1,95/2) * Fixing spelling, and minor bugs in feature files. * Implemented requested changes by @qvalentin * Some more cleanup. * Implemented return value, and Cucumber Steps. * It seems that deleteAll doesnt work, so we need to do that. * WIP: update tests. * Fixed broken merge. * Fixed Tests, finished implementing. * Added one more scenario * Bumped Version to v0.0.7 * Implemented changes by @qvalentin Co-authored-by: qvalentin <valentin.theodor@web.de>

open-schnick added 3 commits December 25, 2020 17:56

FF-251 Added basic structure and exception + handler.

98d0550

Cleanup. Reworked custom Exceptions.

7f03f3f

Cleanup. Implemented Change in UnitTests.

8603fdf

open-schnick added Feature Feature Label BugFix / Cleanup Bugfixes, Cleanups, Small changes labels Dec 26, 2020

open-schnick requested a review from a team December 26, 2020 16:01

open-schnick changed the title ~~Feature/ff 251~~ FF-251 Delete FileSystemItem API Endpoint Dec 26, 2020

Cleanup. Implemented necessary changes to cucumber steps

a3f6460

added the .feature file for deleting

0324924

open-schnick commented Dec 27, 2020

View reviewed changes

src/test/java/de/filefighter/rest/cucumber/ViewFolderContentsSteps.java Outdated Show resolved Hide resolved

open-schnick and others added 9 commits December 27, 2020 12:38

FileSystemItem now includes the User

e0d388a

fixed copy pesto, added step function

9dff8a4

removed the empty lines

1aae46c

minor fixes, recusive scenarion for permissions

f597afd

Merge remote-tracking branch 'origin/feature/FF-251' into feature/FF-251

bdca270

Cleanup. Refactored getContentsOfFolder.

0f30212

Commented out feature.

cc5db3a

Implemented TODO, updated tests.

5d52a17

WIP. basic structure, added wip comments

b47ecd9

WIP. added checks for invisible entities.

3c11c0f

qvalentin reviewed Dec 30, 2020

View reviewed changes

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java Outdated Show resolved Hide resolved

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java Outdated Show resolved Hide resolved

open-schnick added 4 commits December 30, 2020 18:26

WIP. started implementing. Added more comments.

763d05b

Fixed Tests.

9d39e6a

FF-251 finished adding logic.

7cbe309

Added UnitTests (1/2)

b9abd26

qvalentin reviewed Jan 3, 2021

View reviewed changes

added some comments to understand the recursion

77735a6

qvalentin reviewed Jan 3, 2021

View reviewed changes

src/test/java/de/filefighter/rest/cucumber/CommonCucumberSteps.java Outdated Show resolved Hide resolved

src/test/java/de/filefighter/rest/cucumber/ViewFolderContentsSteps.java Outdated Show resolved Hide resolved

open-schnick added 3 commits January 3, 2021 15:56

Fixing, refactoring.

e41df8e

Added UnitTests (1,95/2)

9492db9

merge. included @qvalentin 's comments.

1269dab

open-schnick commented Jan 3, 2021

View reviewed changes

src/test/java/de/filefighter/rest/cucumber/ViewFolderContentsSteps.java Outdated Show resolved Hide resolved

open-schnick commented Jan 3, 2021

View reviewed changes

src/test/java/de/filefighter/rest/cucumber/ViewFolderContentsSteps.java Outdated Show resolved Hide resolved

Fixing spelling, and minor bugs in feature files.

e634d35

open-schnick commented Jan 3, 2021

View reviewed changes

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java Outdated Show resolved Hide resolved

open-schnick added 9 commits January 3, 2021 16:38

Implemented requested changes by @qvalentin

aec4c15

Some more cleanup.

6443646

Implemented return value, and Cucumber Steps.

b2b0134

It seems that deleteAll doesnt work, so we need to do that.

551d83a

WIP: update tests.

6decf6c

Merge branch 'master' into feature/FF-251

f174c4e

# Conflicts: # src/main/java/de/filefighter/rest/domain/filesystem/data/persistence/FileSystemEntity.java # src/test/java/de/filefighter/rest/domain/user/business/UserBusinessServiceUnitTest.java

Fixed broken merge.

c85c4bf

Fixed Tests, finished implementing.

189739f

Added one more scenario

cf9f3d1

open-schnick marked this pull request as ready for review January 9, 2021 11:16

Bumped Version to v0.0.7

4d46bbe

qvalentin approved these changes Jan 9, 2021

View reviewed changes

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java Outdated Show resolved Hide resolved

src/test/resources/ViewFolderContents.feature Outdated Show resolved Hide resolved

src/test/resources/deleteFileSystemItems.feature Show resolved Hide resolved

Implemented changes by @qvalentin

7d7349d

open-schnick merged commit d42da81 into master Jan 9, 2021

open-schnick deleted the feature/FF-251 branch January 9, 2021 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FF-251 Delete FileSystemItem API Endpoint #62

FF-251 Delete FileSystemItem API Endpoint #62

Uh oh!

open-schnick commented Dec 26, 2020

Uh oh!

open-schnick commented Dec 26, 2020 •

edited

Loading

Uh oh!

Uh oh!

open-schnick commented Dec 27, 2020

Uh oh!

open-schnick commented Dec 29, 2020

Uh oh!

qvalentin commented Dec 29, 2020

Uh oh!

open-schnick commented Dec 29, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

qvalentin left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FF-251 Delete FileSystemItem API Endpoint #62

FF-251 Delete FileSystemItem API Endpoint #62

Uh oh!

Conversation

open-schnick commented Dec 26, 2020

Uh oh!

open-schnick commented Dec 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

open-schnick commented Dec 27, 2020

Uh oh!

open-schnick commented Dec 29, 2020

Uh oh!

qvalentin commented Dec 29, 2020

Uh oh!

open-schnick commented Dec 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qvalentin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

open-schnick commented Dec 26, 2020 •

edited

Loading

open-schnick commented Dec 29, 2020 •

edited

Loading