Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

open-schnick
Copy link
Member

No description provided.

@open-schnick open-schnick added the Feature Feature Label label Nov 2, 2020
@open-schnick open-schnick requested a review from a team November 2, 2020 08:15
Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writing stepfunctions seem quite easy actually with the whole springboot setup

fileSystemRepository.save(FileSystemEntity
.builder()
.isFile(true)
.id(fsItemId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is path ignored?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm @qvalentin this is fixed one commit later :D

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #7 into master will decrease coverage by 0.90%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
- Coverage     53.94%   53.03%   -0.91%     
- Complexity       92       96       +4     
============================================
  Files            47       49       +2     
  Lines           317      313       -4     
  Branches          5        5              
============================================
- Hits            171      166       -5     
- Misses          146      147       +1     
Impacted Files Coverage Δ Complexity Δ
...ighter/rest/configuration/PrepareDataBaseProd.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...efighter/rest/configuration/RestConfiguration.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...main/filesystem/rest/FileSystemRestController.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
.../domain/filesystem/rest/FileSystemRestService.java 14.28% <ø> (ø) 1.00 <0.00> (ø)
...domain/health/rest/SystemHealthRestController.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...main/permission/rest/PermissionRestController.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
.../domain/permission/rest/PermissionRestService.java 25.00% <ø> (ø) 1.00 <0.00> (ø)
...hter/rest/domain/user/rest/UserRestController.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...fighter/rest/domain/user/rest/UserRestService.java 14.28% <ø> (ø) 1.00 <0.00> (ø)
.../de/filefighter/rest/rest/RestErrorController.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df47e16...a96da4b. Read the comment docs.

@open-schnick
Copy link
Member Author

@qvalentin yes it should be really easy. I implemented in the last commit a possibility to consume the endpoints, and share the result between step files.

@open-schnick open-schnick marked this pull request as ready for review November 2, 2020 11:18
@open-schnick open-schnick merged commit f8047c9 into master Nov 2, 2020
@open-schnick open-schnick deleted the feature/finishStructureAndCucumber branch November 2, 2020 12:27
Gimleux pushed a commit that referenced this pull request May 20, 2021
* added some CommonCucumberSteps

* added remaining BusinessServices

* WIP! in HATEOAS is too much hate.

* Fixed Constructor bug, added some more run configs.

* Fixed CucumberTests

* Fixed missing run config

* refactored file path header to config file, added rest template bean

* added rest template to test api endpoints.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature Feature Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants