Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

open-schnick
Copy link
Member

Checkout the feature files. Unit tests are still to come.

@open-schnick open-schnick requested a review from a team November 3, 2020 17:52
@open-schnick open-schnick added the Feature Feature Label label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #9 into master will increase coverage by 4.51%.
The diff coverage is 54.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
+ Coverage     54.54%   59.06%   +4.51%     
- Complexity       98      136      +38     
============================================
  Files            49       52       +3     
  Lines           319      491     +172     
  Branches          5       19      +14     
============================================
+ Hits            174      290     +116     
- Misses          145      188      +43     
- Partials          0       13      +13     
Impacted Files Coverage Δ Complexity Δ
.../java/de/filefighter/rest/domain/common/Utils.java 0.00% <0.00%> (ø) 1.00 <1.00> (?)
...main/token/data/persistance/AccessTokenEntity.java 66.66% <ø> (+66.66%) 4.00 <0.00> (+4.00)
...token/exceptions/AccessTokenNotFoundException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...omain/user/exceptions/UserAlreadyExistsAdvise.java 33.33% <0.00%> (ø) 1.00 <0.00> (ø)
...user/exceptions/UserNotAuthenticatedException.java 100.00% <ø> (+100.00%) 2.00 <0.00> (+2.00)
...est/domain/user/exceptions/UserNotFoundAdvice.java 33.33% <0.00%> (ø) 1.00 <0.00> (ø)
.../domain/user/exceptions/UserNotFoundException.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fighter/rest/domain/user/role/GroupRepository.java 25.00% <25.00%> (+5.00%) 2.00 <1.00> (+1.00)
...ilefighter/rest/configuration/PrepareDataBase.java 38.15% <33.33%> (-9.47%) 6.00 <2.00> (+2.00) ⬇️
...in/token/exceptions/AccessTokenNotFoundAdvise.java 33.33% <50.00%> (ø) 1.00 <1.00> (?)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e9d13...1d0b1a7. Read the comment docs.

Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked everything yet

@open-schnick
Copy link
Member Author

@qvalentin check the userAuth feature again pls. Look at the status codes and response messages.

@open-schnick open-schnick marked this pull request as ready for review November 5, 2020 09:00
@open-schnick open-schnick merged commit 90ee2b2 into master Nov 5, 2020
@open-schnick open-schnick deleted the feature/userAuthorization branch November 5, 2020 12:16
Gimleux pushed a commit that referenced this pull request May 20, 2021
Gimleux pushed a commit that referenced this pull request May 20, 2021
* Added Steps, and fixed feature

* Added default users for dev, fixed wrong param names "roles"

* FF-89 implemented logic, fixed cucumber tests.

* Implemented requested changes by @qvalentin (#9)

* Fixed test.

* Added UnitTests (1/2) - Some Cleanup

* Added UnitTests (2/2) - Cleanup, fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Feature Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants