Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

qvalentin
Copy link
Member

No description provided.

@qvalentin qvalentin requested a review from open-schnick April 2, 2021 09:29
@qvalentin qvalentin force-pushed the feature/rewriteFeatureFiles branch from e75558e to e6bf210 Compare April 2, 2021 09:30
@open-schnick open-schnick changed the title ViewFolderContents updated to new sharing concept FF-330 - ViewFolderContents updated to new sharing concept Apr 4, 2021
@qvalentin
Copy link
Member Author

LinkedBlockingQueue is cool.
@open-schnick seems like you did not push some files. Compiling fails.

@open-schnick
Copy link
Member

@open-schnick seems like you did not push some files. Compiling fails.

ups. didn't check that.

@open-schnick open-schnick marked this pull request as ready for review April 13, 2021 19:26
@open-schnick open-schnick requested review from a team and removed request for open-schnick April 13, 2021 19:28
Copy link
Member Author

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@open-schnick open-schnick merged commit 91b4503 into master Apr 14, 2021
@open-schnick open-schnick deleted the feature/rewriteFeatureFiles branch April 14, 2021 17:18
Gimleux pushed a commit that referenced this pull request May 20, 2021
* ViewFolderContents updated to new sharing concept

* Implemented Refactorings from FF-296

* start with delete FeatureFile

* Rewrote part of the logic, Implemented Ownerids, renamed to lastupdated.

* adapt feature files to refactoring

* minor changes.

* Fixed failing request. Happy Easter btw lol

* minor fix of feature files

* Implemented getFolderContents with feature file.

* Rewrote Deletion Endpoint.

* Implemented recursive updating of timestamps

* Updated Tests, fixed cov.

* fix some preperation steps for delte, add check for last modified

* dirty hack, have a better idea ?

* bad things happen when you forget about that one little change you made ages ago

* Finished UnitTests. Changed logger level to debug.

* add return values to delte feature file

* FF-331 rewrote deletion endpoint logic for the 12398th time.

* Fixed tests.

* Added missing coverage.

Co-authored-by: open-schnick <jonathan.burst@gmx.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants