Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Feature/add user #11

Merged
merged 21 commits into from
Nov 24, 2020
Merged

Feature/add user #11

merged 21 commits into from
Nov 24, 2020

Conversation

Gimleux
Copy link
Member

@Gimleux Gimleux commented Nov 21, 2020

No description provided.

@Gimleux Gimleux added the enhancement New feature or request label Nov 21, 2020
@Gimleux Gimleux changed the base branch from master to review November 22, 2020 07:59
qvalentin
qvalentin approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

webapp_frontend/src/assets/images/icons/material.io/check_circle-24px.svg
@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M0 0h24v24H0z" fill="none"/><path d="M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm-2 15l-5-5 1.41-1.41L10 14.17l7.59-7.59L19 8l-9 9z" fill="green"/></svg> No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternativly we could use: https://icons.getbootstrap.com/

qvalentin
qvalentin suggested changes Nov 22, 2020
View reviewed changes
Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting the group(s) should also be possible.

@Gimleux
Copy link
Member Author

Gimleux commented Nov 23, 2020

Selecting the group(s) should also be possible.

Will be discussed in next meeting

@Gimleux Gimleux marked this pull request as ready for review November 23, 2020 15:06
qvalentin
qvalentin suggested changes Nov 23, 2020
View reviewed changes
@Gimleux Gimleux requested a review from qvalentin November 23, 2020 20:18
qvalentin
qvalentin approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just change the text, then we can merge

@qvalentin
Copy link
Member

the password check kind of sucks, I cant past my password, and I also can't remove the first letter that I put in

@Gimleux
Copy link
Member Author

Gimleux commented Nov 24, 2020

the password check kind of sucks, I cant past my password, and I also can't remove the first letter that I put in

you just cannot paste a password if it is > maxLength
There should be an error visible

@Gimleux
Copy link
Member Author

Gimleux commented Nov 24, 2020

I also can't remove the first letter that I put in

solved

@Gimleux Gimleux merged commit 446579e into review Nov 24, 2020
@Gimleux Gimleux deleted the feature/addUser branch November 24, 2020 10:56
Gimleux added a commit that referenced this pull request May 20, 2021
@Gimleux
Merge pull request #11 from FileFighter/feature/addUser
a1656dd 
Feature/add user
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@qvalentin qvalentin qvalentin approved these changes

@open-schnick open-schnick open-schnick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gimleux @qvalentin @open-schnick