Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

qvalentin
Copy link
Member

No description provided.

@qvalentin qvalentin requested a review from open-schnick March 27, 2021 10:54
Comment on lines +6 to +11

include /etc/nginx/mime.types;
default_type application/octet-stream;
access_log /var/log/nginx/access.log;
sendfile on;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to add default timeouts and upload body size. otherwise users cannot upload large files right?

Copy link
Member

@open-schnick open-schnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@qvalentin qvalentin changed the base branch from master to feature/review May 10, 2021 14:51
@qvalentin qvalentin merged commit ce7c3cc into feature/review May 10, 2021
@qvalentin qvalentin deleted the feature/nginxHosting branch May 10, 2021 15:20
open-schnick pushed a commit that referenced this pull request May 13, 2021
* Upload basics(#117)

* add basic handleMultipleApiActions method and redux store

* finish handle multiple api actions, implement it for delete and upload

* add dropzone lib, improve redux store

* test some file download stuff

* move current folder content to redux store, so we can update it after uploading

* update snapshot

* adust fsEnity model to new refactored model

* basics logic for preflight wip

* add basic components for overwrite merge dialog

* broken stuff

* overwrite / merge / rename basic functional

* selecting all and checking if name is valid

* Yes it is possible to make a 100+ lines method readable, here is how!

* remove debug

* demo deltete

* add second preflight logic

* remove file when they are deleted, fix preflight result parser

* add constant for Filehandler url, map download button

* add basic download functiality

* update tests

* cant fix this test

* fix some bugs with preflight handling

* fix snapshot by removing modal

* handle response for upload

* fix comparion of paths

* remove debug

* ADD_TO_CONTENTS reducer now removes duplicates

* use nginx for hosting and include reverse proxy features (#124)

* use nginx for hosting and include reverse proxy features

* use recomended tagging and updating in dockerfile

* gitignore

* tweak nginx config

* fix proxy pass for fh

* try to fix proxy for fe

* try fe proxy when file does not exist (fallback to index)

* fix proxy redirect to backend

* Integrate Upload fixes (#153)

* fix adding new fsEntities and add currentID

* fix es lint

* fix upload of empty folder and currentFsItemId check

* update test

* remove hardcoded fileIDS

* fix current ID header parsing, design changes

* add action to overwrite/merge all button

* increase client_max_body_size of rest api

* change constants

* requested changes by @open-schnick
Gimleux pushed a commit that referenced this pull request May 20, 2021
* Upload basics(#117)

* add basic handleMultipleApiActions method and redux store

* finish handle multiple api actions, implement it for delete and upload

* add dropzone lib, improve redux store

* test some file download stuff

* move current folder content to redux store, so we can update it after uploading

* update snapshot

* adust fsEnity model to new refactored model

* basics logic for preflight wip

* add basic components for overwrite merge dialog

* broken stuff

* overwrite / merge / rename basic functional

* selecting all and checking if name is valid

* Yes it is possible to make a 100+ lines method readable, here is how!

* remove debug

* demo deltete

* add second preflight logic

* remove file when they are deleted, fix preflight result parser

* add constant for Filehandler url, map download button

* add basic download functiality

* update tests

* cant fix this test

* fix some bugs with preflight handling

* fix snapshot by removing modal

* handle response for upload

* fix comparion of paths

* remove debug

* ADD_TO_CONTENTS reducer now removes duplicates

* use nginx for hosting and include reverse proxy features (#124)

* use nginx for hosting and include reverse proxy features

* use recomended tagging and updating in dockerfile

* gitignore

* tweak nginx config

* fix proxy pass for fh

* try to fix proxy for fe

* try fe proxy when file does not exist (fallback to index)

* fix proxy redirect to backend

* Integrate Upload fixes (#153)

* fix adding new fsEntities and add currentID

* fix es lint

* fix upload of empty folder and currentFsItemId check

* update test

* remove hardcoded fileIDS

* fix current ID header parsing, design changes

* add action to overwrite/merge all button

* increase client_max_body_size of rest api

* change constants

* requested changes by @open-schnick
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants