Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Design Login #130

Merged
merged 11 commits into from
Apr 19, 2021
Merged

Design Login #130

merged 11 commits into from
Apr 19, 2021

Conversation

Gimleux
Copy link
Member

@Gimleux Gimleux commented Apr 18, 2021

No description provided.

@Gimleux Gimleux added the enhancement New feature or request label Apr 18, 2021
@Gimleux Gimleux requested a review from qvalentin April 18, 2021 22:59
@Gimleux Gimleux self-assigned this Apr 18, 2021
@Gimleux Gimleux changed the title Feature/rework login Design Login Apr 18, 2021
@cypress
Copy link

cypress bot commented Apr 18, 2021 •
edited
Loading


Test summary

1 • 3 • 0 • 0

Run details
Project WebApp
Status Failed
Commit b33d2fb
Started Apr 19, 2021 5:15 PM
Ended Apr 19, 2021 5:15 PM
Duration 00:40 💡
OS Linux Ubuntu - 16.04
Browser Electron 87

View run in Cypress Dashboard ➡️

Failures

filesystem.js 1 Failed
1 The filesystem page > changes the url when you click on a file
login_spec.js 1 Failed
1 The Home Page > sets auth cookie when logging in via form submission
register_spec.js 1 Failed
1 The register Page > registers a user successfully

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

qvalentin
qvalentin suggested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great, why no story yet?

qvalentin
qvalentin reviewed Apr 19, 2021
View reviewed changes
qvalentin
qvalentin approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged

@Gimleux Gimleux merged commit 06590e7 into master Apr 19, 2021
@Gimleux Gimleux deleted the feature/reworkLogin branch April 19, 2021 17:45
Gimleux added a commit that referenced this pull request May 20, 2021
@Gimleux
Merge pull request #130 from FileFighter/feature/reworkLogin
423feb1 
Design Login
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@qvalentin qvalentin qvalentin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Gimleux Gimleux

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gimleux @qvalentin