Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

FF-404 add password preHashing with sha (we will hash again in the Backend) #159

Merged
merged 7 commits into from
May 17, 2021
Merged

FF-404 add password preHashing with sha (we will hash again in the Backend) #159

merged 7 commits into from
May 17, 2021

Conversation

qvalentin
Copy link
Member

No description provided.

@open-schnick open-schnick changed the title FF-404 add password preHashin with sha (we will hash again in the Backedn) FF-404 add password preHashing with sha (we will hash again in the Backend) May 15, 2021
open-schnick
open-schnick approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@open-schnick open-schnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a static salt to the hash :)

@cypress
Copy link

cypress bot commented May 15, 2021 •
edited
Loading


Test summary

1 • 5 • 0 • 0

Run details
Project WebApp
Status Failed
Commit 58777d5
Started May 17, 2021 6:57 AM
Ended May 17, 2021 6:59 AM
Duration 01:36 💡
OS Linux Ubuntu - 16.04
Browser Electron 89

View run in Cypress Dashboard ➡️

Failures

filesystem.js 3 Failed
1 The filesystem page > changes the url when you click on a file
2 The filesystem page > goes back to the home of the filesystem
3 The filesystem page > shows error message when a path does not exist
login_spec.js 1 Failed
1 The Home Page > sets auth cookie when logging in via form submission
register_spec.js 1 Failed
1 The register Page > registers a user successfully

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@qvalentin qvalentin merged commit 9d0c940 into master May 17, 2021
@qvalentin qvalentin deleted the feature/FF-173-hashPasswords branch May 17, 2021 07:38
Gimleux pushed a commit that referenced this pull request May 20, 2021
@qvalentin @code-factor
FF-404 add password preHashing with sha (we will hash again in the Ba…
f243e3c 
…ckend) (#159)

* add password preHashin with sha (we will hash again in the Backedn)

* add reference

* [CodeFactor] Apply fixes to commit 61a4df8

* add a static salt before hashing

* make hashed password HEX code uppercase

Co-authored-by: codefactor-io <support@codefactor.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@open-schnick open-schnick open-schnick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qvalentin @open-schnick @code-factor