This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Feature/files context menu #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
qvalentin
reviewed
May 17, 2021
| color: "secondary" | ||
| }; | ||
|
|
||
| function FileIcon(isFolder: boolean, name: string): ReactElement { |
There was a problem hiding this comment.
Nice that this is a component now, the backend also provides information about the exact mimetype and the general type, we could use this to improve this (then you dont have to list all the file extensions )
qvalentin
approved these changes
May 18, 2021
| <Button type="submit">Download</Button> | ||
| <Button onClick={handleDeleteClicked} disabled={props.selectedFsEntities.length < 1}>Delete</Button> | ||
| <form method="get" className="d-inline" | ||
| action={constants.url.FH_URL + "/download?ids=" + props.selectedFsEntities.map((e: FsEntity) => e.fileSystemId)}> |
There was a problem hiding this comment.
How does this add the ";" im confused?
qvalentin
added a commit
that referenced
this pull request
May 19, 2021
* Extracted FileIcon * Corrected Typo in FileEntities * Corrected Typo in FileEntities * Add FileListContextMenu Basic * WIP Context menu * Positioning Context Menu * changed context menu items * Added icons * Added commits * removed context menu on right click * refactoring * extracted sorting method * remove else * removed else in arrays.ts * removed else in serviceWorker * remove else in sortFilesAndFolders * added drop down menu * rename fileList Header * WIP Context Menu Content * Basic Menu done * Implemented Download to Dropdown Menu * fixed bug in filesystem toolbar which allowed to click buttons when they are faded out * Added Binary Icon * Refactored FileIcons * Code Style * updated snapshot tests * install husky * resolved issue with missing dropdown indicator * add query parameters to form by input tags * add query parameter forwarding to nginx Co-authored-by: qvalentin <valentin.theodor@web.de>
Gimleux
added a commit
that referenced
this pull request
May 20, 2021
* Extracted FileIcon * Corrected Typo in FileEntities * Corrected Typo in FileEntities * Add FileListContextMenu Basic * WIP Context menu * Positioning Context Menu * changed context menu items * Added icons * Added commits * removed context menu on right click * refactoring * extracted sorting method * remove else * removed else in arrays.ts * removed else in serviceWorker * remove else in sortFilesAndFolders * added drop down menu * rename fileList Header * WIP Context Menu Content * Basic Menu done * Implemented Download to Dropdown Menu * fixed bug in filesystem toolbar which allowed to click buttons when they are faded out * Added Binary Icon * Refactored FileIcons * Code Style * updated snapshot tests * install husky * resolved issue with missing dropdown indicator * add query parameters to form by input tags * add query parameter forwarding to nginx Co-authored-by: qvalentin <valentin.theodor@web.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.