Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

Gimleux
Copy link
Member

@Gimleux Gimleux commented Nov 24, 2020

No description provided.

@Gimleux Gimleux self-assigned this Nov 24, 2020
<title>FileFighter</title>
</head>
<body>
<body class="h-100">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do my best to follow your instructions, your grace

-->
<div id="root" class="d-flex flex-column h-100"></div>
<!--Black Lives Matter!-->
<!--Queer Lives Matter!-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also add this to the banner of our blog if you want

Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="en" class="h-100">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you really put styles on this element?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, works totally fine


return (
<Container>
<Container className="h-100" style={{position: "relative"}}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a class instead of inline style. Maybe class name pos-rel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR is still marked as a draft this one is still in progress and not finished. Was just experimenting and will be replaced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saved it in a WIP commit because I had no time left to work on it

@qvalentin
Copy link
Member

qvalentin commented Dec 4, 2020

@Gimleux the navbar is not working correctly. You need to use the React Bootstrap version: https://react-bootstrap.netlify.app/components/navbar/

otherwise the JS will not be working

@Gimleux Gimleux marked this pull request as ready for review December 4, 2020 16:03
@Gimleux Gimleux requested a review from qvalentin December 4, 2020 16:30
@qvalentin qvalentin merged commit 9bf7be0 into review Dec 4, 2020
@Gimleux Gimleux deleted the feature/feStructure branch December 4, 2020 23:00
Gimleux added a commit that referenced this pull request May 20, 2021
* changed favicon & logos

* Added Console comments to index.html

* Streched ui to 100%

* Manage CSS for NavBar, Main & Footer

* WIP

* Removed code smell

* trying to save to world aka restore wrong PR

* deleted warning

* Fixed missing catch in Health

* Deleted outdated Health.tsx

* Update README.md

* Added Submit Runner

* Added classes instead of inline styles to submit runner

* Added NavBar

* Added Footer

* Fixed wrong bootstrap in NavBar

* fixed expansion of navbar on mobile

* minpr fixes

* added link to file

* use selfhosted corsanywhere

Co-authored-by: qvalentin <valentin.theodor@web.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants