-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/fe structure #20
Conversation
<title>FileFighter</title> | ||
</head> | ||
<body> | ||
<body class="h-100"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do my best to follow your instructions, your grace
--> | ||
<div id="root" class="d-flex flex-column h-100"></div> | ||
<!--Black Lives Matter!--> | ||
<!--Queer Lives Matter!--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also add this to the banner of our blog if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cheatsheet https://hackerthemes.com/bootstrap-cheatsheet/
@@ -1,5 +1,5 @@ | |||
<!DOCTYPE html> | |||
<html lang="en"> | |||
<html lang="en" class="h-100"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you really put styles on this element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, works totally fine
|
||
return ( | ||
<Container> | ||
<Container className="h-100" style={{position: "relative"}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a class instead of inline style. Maybe class name pos-rel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this PR is still marked as a draft this one is still in progress and not finished. Was just experimenting and will be replaced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saved it in a WIP commit because I had no time left to work on it
@Gimleux the navbar is not working correctly. You need to use the React Bootstrap version: https://react-bootstrap.netlify.app/components/navbar/ otherwise the JS will not be working |
* changed favicon & logos * Added Console comments to index.html * Streched ui to 100% * Manage CSS for NavBar, Main & Footer * WIP * Removed code smell * trying to save to world aka restore wrong PR * deleted warning * Fixed missing catch in Health * Deleted outdated Health.tsx * Update README.md * Added Submit Runner * Added classes instead of inline styles to submit runner * Added NavBar * Added Footer * Fixed wrong bootstrap in NavBar * fixed expansion of navbar on mobile * minpr fixes * added link to file * use selfhosted corsanywhere Co-authored-by: qvalentin <valentin.theodor@web.de>
No description provided.