Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move internal to plugin #422

Closed
wants to merge 13 commits into from

Conversation

tomberek
Copy link

This is not pretty, but was a very rough attempt to see if it would work to expose the plugin system to sops

It results in a sops binary capable of age1yubikey/AGE-PLUGIN-YUBIKEY plugin actions. So that is promising. Is there continued work to do something along these lines?

@FiloSottile
Copy link
Owner

Hey! Yeah, the plan is to expose this API, indeed. Seeing it used is extremely helpful, thank you!

Looks like besides the current internal plugin package, you'd want a function to parse both native and plugin recipients and identities, and a TUI implementation of the callbacks, is that right? Does the age TUI work as-is for SOPS?

@tomberek
Copy link
Author

Yes! Surprisingly these two sets of changes allowed me to use sops + age + age-plugin-yubikey. (warning: I did extremely minimal testing.)

@FiloSottile FiloSottile force-pushed the filippo/plugins branch 4 times, most recently from f234662 to acb1170 Compare May 24, 2022 13:57
@FiloSottile
Copy link
Owner

Thank you for experimenting with this! I plan to expose the plugin API after some cleanup. Closing this because the filippo/plugins branch is being deleted.

@FiloSottile FiloSottile deleted the branch FiloSottile:filippo/plugins July 3, 2022 14:55
@FiloSottile FiloSottile closed this Jul 3, 2022
@tomberek tomberek deleted the filippo/plugins branch July 3, 2022 14:56
@tomberek
Copy link
Author

tomberek commented Aug 6, 2023

Is it happening? 6976c5f

@FiloSottile
Copy link
Owner

Hi! Yeah you should find everything but the TUI in https://pkg.go.dev/filippo.io/age/plugin@v1.1.2-0.20230805193447-c89f0b932ecd. Let me know if it looks good, ideally before the next release :)

@Kranzes
Copy link

Kranzes commented Aug 6, 2023

Awesome! So here's a question, when are we getting a release with this? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants