-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate legacy features on x/token,collection #1201
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 69.74% 69.74%
=======================================
Files 643 643
Lines 67255 67255
=======================================
Hits 46906 46906
Misses 18176 18176
Partials 2173 2173 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update swagger also.
It seems the change does not affect the output for swagger. |
* Deprecate all the x/token features * Deprecate x/collection fungible token features * Deprecate x/collection attach features * Update CHANGELOG.md * Lint * Apply feedbacks on the PR (cherry picked from commit 3babbe5) # Conflicts: # CHANGELOG.md # tests/mocks/types_module_module.go
… (#1202) * chore: deprecate legacy features on x/token,collection (#1201) * Deprecate all the x/token features * Deprecate x/collection fungible token features * Deprecate x/collection attach features * Update CHANGELOG.md * Lint * Apply feedbacks on the PR (cherry picked from commit 3babbe5) # Conflicts: # CHANGELOG.md # tests/mocks/types_module_module.go * Resolve conflicts * Revert updating golangci version --------- Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Description
This patch would deprecate following features on original modules:
Motivation and context
The features would be wiped out from the sdk in the next major release.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml