-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/fswap): introduce new event(MakeSwapProposal) #1363
feat(x/fswap): introduce new event(MakeSwapProposal) #1363
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
==========================================
- Coverage 69.54% 69.54% -0.01%
==========================================
Files 672 672
Lines 56106 56111 +5
==========================================
+ Hits 39018 39020 +2
- Misses 14825 14826 +1
- Partials 2263 2265 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, EventMakeSwap
would be more flexible (please consider upcoming msg-based proposals). Then, the emission should reside in MakeSwap.
3b15e93
to
43bd287
Compare
* feat(x/fswap): introduce new event(MakeSwapProposal) * chore: lint proto * chore: update proto-doc * chore: update changelog * chore: newline * chore: update proto * chore: make the event two separate events (cherry picked from commit 5e2cd7f)
* feat(x/fswap): introduce new event(MakeSwapProposal) * chore: lint proto * chore: update proto-doc * chore: update changelog * chore: newline * chore: update proto * chore: make the event two separate events (cherry picked from commit 5e2cd7f) Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml