Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing router registration #1379

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented May 13, 2024

Description

  • Add missing router registration

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae added A: bug Something isn't working backport/v0.49.x labels May 13, 2024
@jaeseung-bae jaeseung-bae self-assigned this May 13, 2024
@jaeseung-bae jaeseung-bae marked this pull request as ready for review May 13, 2024 00:56
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (ed74ee8) to head (77872fe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   69.58%   69.58%   -0.01%     
==========================================
  Files         668      668              
  Lines       56208    56208              
==========================================
- Hits        39111    39110       -1     
- Misses      14830    14831       +1     
  Partials     2267     2267              
Files Coverage Δ
x/fswap/keeper/keeper.go 51.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

zemyblue
zemyblue previously approved these changes May 13, 2024
0Tech
0Tech previously approved these changes May 13, 2024
@jaeseung-bae jaeseung-bae merged commit e3f3bd7 into main May 13, 2024
38 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/missing-router-register branch May 13, 2024 02:38
mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix: add missing router register

* chore: update changelog

* chore: lint fix

* chore: lint fix

(cherry picked from commit e3f3bd7)

# Conflicts:
#	CHANGELOG.md
jaeseung-bae added a commit that referenced this pull request May 13, 2024
* fix: add missing router register

* chore: update changelog

* chore: lint fix

* chore: lint fix
jaeseung-bae added a commit that referenced this pull request May 13, 2024
* fix: add missing router registration (#1379)

* fix: add missing router register

* chore: update changelog

* chore: lint fix

* chore: lint fix

(cherry picked from commit e3f3bd7)

# Conflicts:
#	CHANGELOG.md

* fix: add missing router registration (#1379)

* fix: add missing router register

* chore: update changelog

* chore: lint fix

* chore: lint fix

* chore: fix changelog

---------

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com>
zemyblue added a commit that referenced this pull request May 13, 2024
* release/v0.49.x:
  fix: add missing router registration (backport #1379) (#1381)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants