Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new query to get a swap (backport #1387) #1389

Merged
merged 2 commits into from
May 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 21, 2024

Description

  • Add new query to get a swap
  • Add missing swagger fswap entry for generation
    • Add new URL for fswap's query json to client/docs/config.json
  • Fix for missing pagination for QuerySwapsRequest CLI

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1387 done by [Mergify](https://mergify.com).

* feat: add new query to get a swap

* chore: update changelog

* fix: add missing pagination param in cli client

* chore: lint fix

* chore: add grpc-query test

* chore: add descriptive message for invalid QuerySwapRequest

* chore: add CLI to query swap

(cherry picked from commit 92ad675)

# Conflicts:
#	client/docs/swagger-ui/swagger.yaml
@mergify mergify bot added the conflicts label May 21, 2024
Copy link
Contributor Author

mergify bot commented May 21, 2024

Cherry-pick of 92ad675 has failed:

On branch mergify/bp/release/v0.49.x/pr-1387
Your branch is up to date with 'origin/release/v0.49.x'.

You are currently cherry-picking commit 92ad67530.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	modified:   client/docs/config.json
	modified:   docs/core/proto-docs.md
	modified:   proto/lbm/fswap/v1/query.proto
	modified:   x/fswap/client/cli/query.go
	modified:   x/fswap/keeper/grpc_query.go
	new file:   x/fswap/keeper/grpc_query_test.go
	modified:   x/fswap/testutil/expected_keepers_mocks.go
	modified:   x/fswap/types/msgs.go
	modified:   x/fswap/types/msgs_test.go
	modified:   x/fswap/types/query.pb.go
	modified:   x/fswap/types/query.pb.gw.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   client/docs/swagger-ui/swagger.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 68.93%. Comparing base (27c7599) to head (68bebbd).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.49.x    #1389   +/-   ##
================================================
  Coverage            68.93%   68.93%           
================================================
  Files                  671      671           
  Lines                69260    69284   +24     
================================================
+ Hits                 47743    47760   +17     
- Misses               19235    19240    +5     
- Partials              2282     2284    +2     
Files Coverage Δ
x/fswap/keeper/grpc_query.go 17.46% <70.00%> (+9.91%) ⬆️
x/fswap/types/msgs.go 32.95% <78.57%> (+8.63%) ⬆️

... and 1 file with indirect coverage changes

zemyblue
zemyblue previously approved these changes May 21, 2024
@jaeseung-bae jaeseung-bae merged commit 95ac830 into release/v0.49.x May 21, 2024
31 checks passed
@jaeseung-bae jaeseung-bae deleted the mergify/bp/release/v0.49.x/pr-1387 branch May 21, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants