-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add suffix string to docker container #1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, it should be deleted if the containerProtoGen already exist instead of starting. Because this change assumes that the container will be regenerated every execution moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, we may just append the project name to the name of the container, which prevents the reuse by other projects.
Yes, It is. It should be deleted.
Thanks for the comment, I'll try this one. |
…swagger generation" This reverts commit 80d61b1.
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0)
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0)
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0) Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0) Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Description
refresh docker container's bound volume which refer to current working directoryWithout refreshing docker container with bound volume location,It doesn't generateproto
,swagger
depending on the current working directory~/Finschia/fisnchia-sdk
~/xxx/finschia-sdk
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml