This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Fix bug in $firebase.remove. #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$q.all was previously getting called with an empty array when you tried to delete a query. The array was being populated asynchronously, but $q.all was called before those async called returned.
|
Changes Unknown when pulling 9a41c4b on jamestalmage:remove-bug into * on firebase:master*. |
There was a problem hiding this comment.
You need to do a double call to flushAll() for this test to pass.
Seems like a bug somewhere. (Mockfirebase maybe?).
|
Changes Unknown when pulling 06608d6 on jamestalmage:remove-bug into * on firebase:master*. |
There was a problem hiding this comment.
Declared and not used : ( Great find.
There was a problem hiding this comment.
Thank Webstorm for that one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$q.all was previously getting called with an empty array when you tried to delete a query. The array was being populated asynchronously, but $q.all was called before those async calls returned.