Skip to content

Conversation

annajowang
Copy link
Collaborator

@annajowang annajowang commented Sep 16, 2025

move main adapter build function to index.ts.

In the future we probably want to move some implementation details back into some internal file (not included in tsconfig.json).

@annajowang annajowang marked this pull request as ready for review September 16, 2025 20:31
@annajowang annajowang requested review from a team as code owners September 16, 2025 20:31
Copy link
Collaborator

@Yuangwang Yuangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question - how does this make local build callable?

@annajowang
Copy link
Collaborator Author

Just one question - how does this make local build callable?
it makes adapterbuild() directly importable / callable by the firebase CLI rather than making the firebase CLI call npm exec apphosting-local-build
index.ts is part of the "include" of tsconfig.js.
adapter-builds.ts is not. considered adding adapter-build.ts to the include list. but i think it's preferable to keep that list short and not include everything, later when more impelmentation logic / details is added, we should do them through helper functions not directly in the index.ts file

@annajowang annajowang merged commit fd276b3 into main Sep 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants