Add basic SvelteKit support #56
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
|
||
| // https://github.com/jthegedus/svelte-adapter-firebase/blob/main/src/files/firebase-to-svelte-kit.js | ||
| function toSvelteKitRequest(request: Request) { | ||
| // Firebase sometimes omits the protocol used. Default to http. |
There was a problem hiding this comment.
gen2 functions should handle x-forwarded correctly, so these lines shouldn't be needed any longer—give it a spin in prod though
There was a problem hiding this comment.
From what I can tell, this seems to be on the only way to get the actual full host to pass as the base in the URL constructor that follows. I couldn't find a way to piece together the host without using these headers.
|
Can you write tests for the 3 functions you are introducing? |
|
The deployed demo app is not totally functional yet. The Wordle clone doesn't work, I think due to some issues with cookies. It works fine locally, just seeing issues when deployed. I'm investigating further. |
Tested with SvelteKit demo app, which includes static and server-side rendered pages, API routes, and form actions.