Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script ignores non-standard ports [CORE2919] #3302

Closed
firebird-issue-importer opened this issue Mar 11, 2010 · 6 comments
Closed

Installation script ignores non-standard ports [CORE2919] #3302

firebird-issue-importer opened this issue Mar 11, 2010 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @AlexPeshkoff

Bug was reported initially by Kuznetsov Eugene in fbdevel.
---------------------------
In firebird2/builds/install/arch-specific/linux/misc/postinstall.sh.in
there are lines:

#⁠ Update /etc/services
newLine="gds_db 3050/tcp #⁠ Firebird SQL Database Remote Protocol"
replaceLineInFile /etc/services "$newLine" "^gds_db"

In our case with configuration command
./autogen.sh --prefix=/usr/local/fb214_0308 --with-service-name=gds_db02 --with-service-port=3052
in /etc/inetd.conf we see
gds_db02 stream tcp nowait.30000 firebird /usr/local/fb214_0308/bin/fb_inet_server fb_inet_s
but there is no string for gds_db02 in /etc/services.

Thus, --with-service-name/--with-service-port configure params are processed
incorrectly - non-standard service name isn't added in /etc/services
and non-standard port is ignored.

HPUX script for Classic
(firebird2/builds/install/arch-specific/hpux/classic/postInstall.sh.in)
is more correct:

FileName=/etc/services
newLine="@FB\_SERVICE\_NAME@          @FB\_SERVICE\_PORT@/tcp  #⁠ Firebird SQL Database Remote Protocol"
    replaceLineInFile "$FileName" "$newLine" "^@FB\_SERVICE\_NAME@"

P.S.

Scripts for AIX (firebird2/builds/install/arch-specific/aix/misc/postinstall.sh.in),
FreeBSD (firebird2/builds/install/arch-specific/freebsd/install.sh.in),
HPUX SS (firebird2/builds/install/arch-specific/hpux/super/postInstall.sh.in),
NetBSD (firebird2/builds/install/arch-specific/netbsd/install.sh.in),
Solaris (firebird2/builds/install/arch-specific/solaris/CS/postinstall.in
& firebird2/builds/install/arch-specific/solaris/SS/postinstall.in)
are also undergone.

FB 2.1 (B2_1_Release) is also concerned.
Maybe, FB 2.0 as well, but I didn't check.

Commits: 717872d a558667 d73e847 c2f82be

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 11, 2010

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 11, 2010

Commented by: @AlexPeshkoff

For some platforms fixing is almost unreal - install files not always pass through autoconf-generated scripts, therefore replacing defaults to configured values is problematic.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2010

Commented by: @AlexPeshkoff

Fixed for linux and some other platforms. Others require access to that paltforms to make sure it works. FreeBSD will be fixed at the same time with fixing install on it.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2010

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.0.6 [ 10303 ]

Fix Version: 2.5 RC3 [ 10381 ]

Fix Version: 2.1.4 [ 10361 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 4, 2011

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 28, 2015

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment