Skip to content

Installation script ignores non-standard ports [CORE2919] #3302

@firebird-automations

Description

@firebird-automations

Submitted by: @AlexPeshkoff

Bug was reported initially by Kuznetsov Eugene in fbdevel.
---------------------------
In firebird2/builds/install/arch-specific/linux/misc/postinstall.sh.in
there are lines:

#⁠ Update /etc/services
newLine="gds_db 3050/tcp #⁠ Firebird SQL Database Remote Protocol"
replaceLineInFile /etc/services "$newLine" "^gds_db"

In our case with configuration command
./autogen.sh --prefix=/usr/local/fb214_0308 --with-service-name=gds_db02 --with-service-port=3052
in /etc/inetd.conf we see
gds_db02 stream tcp nowait.30000 firebird /usr/local/fb214_0308/bin/fb_inet_server fb_inet_s
but there is no string for gds_db02 in /etc/services.

Thus, --with-service-name/--with-service-port configure params are processed
incorrectly - non-standard service name isn't added in /etc/services
and non-standard port is ignored.

HPUX script for Classic
(firebird2/builds/install/arch-specific/hpux/classic/postInstall.sh.in)
is more correct:

FileName=/etc/services
newLine="@FB\_SERVICE\_NAME@          @FB\_SERVICE\_PORT@/tcp  #⁠ Firebird SQL Database Remote Protocol"
    replaceLineInFile "$FileName" "$newLine" "^@FB\_SERVICE\_NAME@"

P.S.

Scripts for AIX (firebird2/builds/install/arch-specific/aix/misc/postinstall.sh.in),
FreeBSD (firebird2/builds/install/arch-specific/freebsd/install.sh.in),
HPUX SS (firebird2/builds/install/arch-specific/hpux/super/postInstall.sh.in),
NetBSD (firebird2/builds/install/arch-specific/netbsd/install.sh.in),
Solaris (firebird2/builds/install/arch-specific/solaris/CS/postinstall.in
& firebird2/builds/install/arch-specific/solaris/SS/postinstall.in)
are also undergone.

FB 2.1 (B2_1_Release) is also concerned.
Maybe, FB 2.0 as well, but I didn't check.

Commits: 717872d a558667 d73e847 c2f82be