exclude_filter doesn't work for <services></section> section of the Trace facility [CORE3168]

[firebird-automations]

Submitted by: Thomas Steinmaurer (tsteinmaurer)

I have the following trace config:

<services>
enabled true
log_services true
exclude_filter "List Trace Sessions"
</services>

Although I've set the exclude filter (also tried without enclosed double quotes), I do get entries like that:

2010-10-07T11:39:12.3090 (1856:0148D0A4) START_SERVICE
service_mgr, (Service 012B6A94, SYSDBA, TCPv4:192.168.142.1,
G:\APPLICAT\FBTraceManager\exe\debug\FBTraceManager.exe:5132)
"List Trace Sessions"
-TRUSTED_SVC SYSDBA -LIST

2010-10-07T11:39:17.3250 (1856:0148D0A4) START_SERVICE
service_mgr, (Service 012B6A94, SYSDBA, TCPv4:192.168.142.1,
G:\APPLICAT\FBTraceManager\exe\debug\FBTraceManager.exe:5132)
"List Trace Sessions"
-TRUSTED_SVC SYSDBA -LIST

I've also tried the following exclude_filter which should dismiss all trace service events:

exclude_filter %Trace%

Running the following SIMILAR TO based query:

select 1 from rdb$database where 'Start Trace Session' similar to '%Trace%'

shows, that the result of the WHERE condition is true, thus fulfills the regular expression, so there is something wrong when evaluating the exclude_filter in the trace facility.

Commits: b48913d 905427a

====== Test Details ======

Test implemented for WINDOWS platform only, checked on WI-V2.5.5.26916 (SS, SC) and WI-V3.0.0.31948 (SS, SC, CS).

[firebird-automations]

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

[firebird-automations]

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.1 [ 10333 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

[firebird-automations]

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-automations]

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Not enough information

Test Details: This config ('my_trace.conf'):

<services>
enabled true
log_services true
exclude_filter "List Trace Sessions"
</services>

And ruinning:

fbtracemgr -sta -c my_trace.conf -se localhost/3255:service_mgr -user sysdba -pas masterke
(or the same: fbsvcmgr localhost/3255:service_mgr user SYSDBA password masterke action_trace_start trc_cfg my_trace.conf)

-- leads to producing:

2015-07-26T11:42:31.6710 (2872:0129DF74) START_SERVICE
service_mgr, (Service 00B0713C, SYSDBA, TCPv4:127.0.0.1, C:\1INSTALL\FIREBIRD\fb25sC\bin\fbtracemgr.exe:4012)
"Start Trace Session"
-TRUSTED_SVC SYSDBA -START -CONFIG <services>
enabled true
log_services true
exclude_filter "List Trace Sessions"
</services>

(in all versions, 2.5.1 - 2.5.5).

For 3.0 config was a little changed:

services
{
enabled = true
log_services = true
exclude_filter = "List Trace Sessions"
}

-- but output of fbtracemgr (fbsvcmgr) also contains this info:

2015-07-26T11:48:06.6870 (2512:01880CE0) START_SERVICE
service_mgr, (Service 01584138, SYSDBA, TCPv4:127.0.0.1, C:\1INSTALL\FIREBIRD\fb30sS\fbtracemgr.exe:420)
"Start Trace Session"
-START -CONFIG services
{
enabled = true
log_services = true
exclude_filter = "List Trace Sessions"
}

So, I can`t understand: does this bug still exists (and is this behavour a *bug* per se ?)

[firebird-automations]

Commented by: @hvlad

Pavel,
you excluded "List Trace Sessions" event, but your command line start *another* service - "Start Trace Session".
Trace output in your sample shows "Start Trace Session" service, not (filtered out by you) "List Trace Sessions".
Do you see the difference ?

[firebird-automations]

Commented by: @pavel-zotov

>> So, I can`t understand: does this bug still exists (and is this behavour a *bug* per se ?)
> you excluded "List Trace Sessions" event, but your command line start *another* service - "Start Trace Session".

Vlad, thanks. I was inattentive.

[firebird-automations]

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Not enough information => Done with caveats

Test Details: This config ('my_trace.conf'):

<services>
enabled true
log_services true
exclude_filter "List Trace Sessions"
</services>

And ruinning:

fbtracemgr -sta -c my_trace.conf -se localhost/3255:service_mgr -user sysdba -pas masterke
(or the same: fbsvcmgr localhost/3255:service_mgr user SYSDBA password masterke action_trace_start trc_cfg my_trace.conf)

-- leads to producing:

2015-07-26T11:42:31.6710 (2872:0129DF74) START_SERVICE
service_mgr, (Service 00B0713C, SYSDBA, TCPv4:127.0.0.1, C:\1INSTALL\FIREBIRD\fb25sC\bin\fbtracemgr.exe:4012)
"Start Trace Session"
-TRUSTED_SVC SYSDBA -START -CONFIG <services>
enabled true
log_services true
exclude_filter "List Trace Sessions"
</services>

(in all versions, 2.5.1 - 2.5.5).

For 3.0 config was a little changed:

services
{
enabled = true
log_services = true
exclude_filter = "List Trace Sessions"
}

-- but output of fbtracemgr (fbsvcmgr) also contains this info:

2015-07-26T11:48:06.6870 (2512:01880CE0) START_SERVICE
service_mgr, (Service 01584138, SYSDBA, TCPv4:127.0.0.1, C:\1INSTALL\FIREBIRD\fb30sS\fbtracemgr.exe:420)
"Start Trace Session"
-START -CONFIG services
{
enabled = true
log_services = true
exclude_filter = "List Trace Sessions"
}

So, I can`t understand: does this bug still exists (and is this behavour a *bug* per se ?)

=>

Test implemented for WINDOWS platform only, checked on WI-V2.5.5.26916 (SS, SC) and WI-V3.0.0.31948 (SS, SC, CS).