Procedures and EXECUTE BLOCK without RETURNS should not be allowed to use SUSPEND [CORE6239]

[firebird-automations]

Submitted by: @pavel-zotov

This SP will be compiled without errors or warnings:

set term ^ ;
create or alter procedure sp_missed_returns_in_its_header as
begin
-- we use SUSPEND clause but there is no
-- output parameters in this SP header:
suspend;
end
^
set term ;^
commit;

But attempt to select from this SP will, of course, fail:

Statement failed, SQLSTATE = 42000
Dynamic SQL Error
-SQL error code = -84
-procedure SP_MISSED_RETURNS_IN_ITS_HEADER does not return any values

Commits: b2b5f9a

[firebird-automations]

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

[firebird-automations]

Modified by: @asfernandes

summary: Compiler can make more rigorous check for presense of RETURNS(...) clause in SP header when SP body contains SUSPEND. => Procedures and EXECUTE BLOCK without RETURNS should not be allowed to use SUSPEND

[firebird-automations]

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

[firebird-automations]

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

[firebird-automations]

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]