Fixed CORE-5823: No permission for SELECT access to blob field in stored procedure. And CORE-5841: No permission for SELECT access to TABLE PLG$SRP in newer snapshot. #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red procedure. And CORE-5841: No permission for SELECT access to TABLE PLG$SRP in newer snapshot.
src/jrd/tra.cpp
Outdated
| tra_fetched_blobs.add(*blob_id); | ||
| tdbb->tdbb_status_vector->clearException(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not use switch() here instead if / else if ?
There was a problem hiding this comment.
Did not notice this when reworked the logic.
hvlad
reviewed
Jun 21, 2018
src/jrd/tra.cpp
Outdated
| { | ||
| if (tdbb->tdbb_status_vector->getErrors()[1] != isc_no_priv) | ||
| throw; | ||
|
|
There was a problem hiding this comment.
Should we check catched exception here, not tdbb_status_vector ?
There was a problem hiding this comment.
OK, I will fix it.
There was a problem hiding this comment.
Thanks, but it seems not enough - few lines below you clear tdbb_status_vector.
It could clear some previous error\warning.
Usually, if code handle exception and not re-throw it, it set temporary status-vector to not overwrite tdbb's one.
|
Does anyone see any problems preventing to merge this PR? I suggest to merge it. |
|
I don't mind merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.