-
-
Notifications
You must be signed in to change notification settings - Fork 259
Wire encryption plugin using chacha cypher #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
builds/posix/Makefile.in
Outdated
chacha: $(CHACHA) | ||
|
||
$(CHACHA): $(Chacha_Objects) $(COMMON_LIB) | ||
$(LINK_PLUGIN) $(call LIB_LINK_SONAME,$(notdir $@).0) -o $@ $^ $(LINK_PLUG_LIBS) $(FIREBIRD_LIBRARY_LINK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing LIB_LINK_DARWIN_INSTALL_NAME
src/plugins/crypt/chacha/ChaCha.cpp
Outdated
|
||
~ChaCha() | ||
{ | ||
delete en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use AutoPtr?
✅ Build firebird 1.0.1201 completed (commit acd9791b83 by @AlexPeshkoff) |
✅ Build firebird 1.0.1220 completed (commit 4ab23b7dc7 by @hvlad) |
With this plugin do Firebird allow using wire encryption with legacy and sspi authentification? |
On 2019-12-24 13:36, Dimitry Sibiryakov wrote:
With this plugin do Firebird allow using wire encryption with legacy
No. Chacha is less critical to key quality but I see no way to have a
session key with DES.
and sspi authentification?
SSPI has many implementations. If windows authentication is using active
directory / kerberos even 'good old' RC4 can be used. With NTLM session
key obviously has very poor quality and RC4 is bad for that case. Chacha
in that case is certainly better but I can't say for sure is it good
enough or not.
PS. The primary goal of adding this plugin is to give an answer to the
people who cry 'RC4 is bad-bad-bad!' not understanding that's it's bad
only in _some_ cases. Well - instead of trying to explain something it's
simpler to add what they want.
|
@AlexPeshkoff : could you provide minimal documentation about it ? At least at firebird.conf. |
On 2019-12-24 20:12, Vlad Khorsun wrote:
@AlexPeshkoff <https://github.com/AlexPeshkoff> : could you provide
minimal documentation about it ? At least at firebird.conf.
Я планирую там доработать кроме документации ещё кое-что но для
успокоения души прошу проверить - свяжется ли c 4 у которой вот такая
строка в firebird.conf:
WireCryptPlugin = ChaCha, Arc4
стандартный клиент от 3 на винде.
A.
|
No description provided.