Work/isql per table stats #7218
Conversation
|
|
||
| const char* PerTableStats::m_itemNames[] = | ||
| { | ||
| " Natural", " Index", |
There was a problem hiding this comment.
It would be cleaner if you use the space in the printf usage instead of in each array member.
There was a problem hiding this comment.
It allows to easily manage alignment and indentation of header names and see it "right now", without compile and run.
src/isql/isql.epp
Outdated
| Firebird::string sIds; | ||
|
|
||
| unsigned maxLen = 0; | ||
| USHORT relId = ~0; |
There was a problem hiding this comment.
Here you can also do the same and use MAX_USHORT.
| Table name | Natural | Index | Insert | Update | Delete | Backout | Purge | Expunge | | ||
| --------------------------------+---------+---------+---------+---------+---------+---------+---------+---------+ | ||
| RDB$INDICES | | 3| | | | | | | | ||
| RDB$RELATION_FIELDS | | 534| | | | | | | |
There was a problem hiding this comment.
Since you have one space in the headers, why not have a space after the numbers?
There was a problem hiding this comment.
Output is already very wide. Also, I satisfied how it looks even without space after numbers :)
Also, reset table names cache when new database is connected.
|
You forgot to add the new setting into "HELP SET" text. |
Done, thanks for reminding me. |
|
QA: see functional/basic/isql/test_06.py |
Per-table run-time statistics in isql.
Details in doc\README.isql_enhancements.txt