RequestBuilder: add .middleware()
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2020
Fishrock123
force-pushed
the
request-builder
branch
from
2c25073
to
2272bbd
Compare
Fishrock123
force-pushed
the
request-builder-with-middleware
branch
from
21f8be5
to
e5ad8f9
Compare
Fishrock123
commented
Jul 27, 2020
A practical implementation of http-rs#192 Some form of this is required in order to make middleware use `surf::Request` and `surf::Response`. Doing so means that those types, particularly request, must own their related `http_types` data. Refs: http-rs#131 This necessitates that `surf::{method}()` return some kind of builder, as is include here as `RequestBuilder`, which includes methods for the common request manipulations when creating new requests. As added convience, the builder can be awaited directly, but does not allow for middleware without use of `Client` due to confusing semantics regarding combining per-request and per-client middleware. PR-URL: http-rs#194
Fishrock123
force-pushed
the
request-builder
branch
from
2272bbd
to
4421645
Compare
A possible addition to http-rs#194, which would be less breaking and possibly more ergonomic, and possibly light enough to warrant doing.
I don't exactly fancy this patch, but here it is anyways. This adds an optional middleware stack to `Request`, allowing `RequestBuilder` and one-off requests to have middleware added onto them, but also allows one-off requests with middleware to have the middleware stack be appended to client middleware for just that request.
Fishrock123
force-pushed
the
request-builder-with-middleware
branch
from
e5ad8f9
to
9f53f13
Compare
Fishrock123
force-pushed
the
request-builder
branch
from
4421645
to
b6113de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible additions to http-rs#194, which would be less breaking and possibly more ergonomic, and possibly light enough to warrant doing.
Open questions:
What to do if"Requestis used in an existingClient? The middleware would be lost. Maybe panic. Maybe do nothing.