Skip to content

Change to only include #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2019
Merged

Change to only include #5

merged 1 commit into from
Apr 15, 2019

Conversation

Engerim
Copy link
Member

@Engerim Engerim commented Apr 11, 2019

No description provided.

@Engerim Engerim requested a review from a team April 11, 2019 10:13
@coveralls
Copy link

coveralls commented Apr 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 63

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 43: 0.0%
Covered Lines: 50
Relevant Lines: 50
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 57

  • 0 of 9 (0.0%) changed or added relevant lines in 2 files are covered.
  • 41 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-100.0%) to 0.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
FlaconiCodingStandard/Sniffs/Test/UseMethodPrefixInTestcaseSniff.php 0 4 0.0%
FlaconiCodingStandard/Sniffs/Test/UseStaticCallsForAssertInTestcaseSniff.php 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
FlaconiCodingStandard/Helper/TestClassHelper.php 5 0.0%
FlaconiCodingStandard/Sniffs/Test/UseMethodPrefixInTestcaseSniff.php 15 0.0%
FlaconiCodingStandard/Sniffs/Test/UseStaticCallsForAssertInTestcaseSniff.php 21 0.0%
Totals Coverage Status
Change from base Build 43: -100.0%
Covered Lines: 0
Relevant Lines: 50
💛 - Coveralls

@Engerim
* use includes for rules instead of excludes
1abb715 
* increase to php 7.3
* use doctrine coding standard as base
* remove phing
@Engerim Engerim force-pushed the change-to-only-include branch from 1b7517b to 1abb715 Compare April 12, 2019 08:12
@Engerim Engerim merged commit b4d981f into master Apr 15, 2019
@Engerim Engerim deleted the change-to-only-include branch April 15, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysL-padawan sysL-padawan sysL-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Engerim @coveralls @sysL-padawan