Ensure percentage split evaluations are consistent in Core API and Local Evaluation #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 39bb81a |
khvn26
reviewed
Jun 27, 2023
| @@ -271,3 +271,63 @@ def test_build_environment_api_key_model(): | |||
|
|
|||
| # Then | |||
| assert environment_key_model.key == environment_key_dict["key"] | |||
|
|
|||
|
|
|||
| def test_build_environment_model_with_deprecated_field(): | |||
There was a problem hiding this comment.
Sorry for being a pedant, but the more -> None annotations are added now, the less we'll suffer when enforcing strict typing later
There was a problem hiding this comment.
Good catch, sorry! Will add now!
There was a problem hiding this comment.
(and never apologise for pedantry!)
gagantrivedi
approved these changes
Jun 28, 2023
Merged
khvn26
requested changes
Jun 28, 2023
| # When/ Then | ||
| assert identity.get_hash_key(use_mv_v2_evaluations) == identity.composite_key | ||
|
|
||
| def test_get_hash_key_with_use_identity_composite_key_for_hashing_enabled(identity): |
There was a problem hiding this comment.
Suggested change
| def test_get_hash_key_with_use_identity_composite_key_for_hashing_enabled(identity): | |
| def test_get_hash_key_with_use_identity_composite_key_for_hashing_enabled( | |
| identity: IdentityModel, | |
| ) -> None: |
|
|
||
| # When/ Then | ||
| assert identity.get_hash_key(use_mv_v2_evaluations) == identity.identifier | ||
| def test_get_hash_key_with_use_identity_composite_key_for_hashing_disabled(identity): |
There was a problem hiding this comment.
Suggested change
| def test_get_hash_key_with_use_identity_composite_key_for_hashing_disabled(identity): | |
| def test_get_hash_key_with_use_identity_composite_key_for_hashing_disabled( | |
| identity: IdentityModel, | |
| ) -> None: |
khvn26
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
use_mv_v2_evaluationwithuse_identity_composite_key_for_hashingto ensure that percentage split evaluations are also consistent between Core, Edge and Local Evaluation.