feat: Add identity overrides to client #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
reviewed
Mar 12, 2024
matthewelwell
approved these changes
Mar 13, 2024
| def update_identity_overrides | ||
| return unless @environment | ||
|
|
||
| @identity_overrides_by_identifier = {} |
There was a problem hiding this comment.
I'm not sure why we need to instantiate this here, and in initialize ?
There was a problem hiding this comment.
In initialize to ensure that it's present even if it's accessed before update_identity_overrides is called and then again in update_identity_overrides to wipe out the stale data on successive runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #42
This change introduces identity overrides to the ruby Flagsmith client. The identity overrides are placed on to the environment model and as an optimization for lookup an identity identifier keyed hash lookup was also added to the client as requested by the linked issue.
Testing
Created a new spec file for local evaluation as there were none present in the repo initially. The spec has to work around some limitations of the local evaluation boot cycle so the shared mocks were only partially used since we need to mock the class, not just an instance, which on boot pulls an initial request from the API.