feat: add audit log when environment feature version is published #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4064 +/- ##
==========================================
+ Coverage 96.42% 96.43% +0.01%
==========================================
Files 1148 1149 +1
Lines 37430 37526 +96
==========================================
+ Hits 36092 36189 +97
+ Misses 1338 1337 -1 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
May 31, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
The main purpose of this PR is to add an AuditLog record when a new EnvironmentFeatureVersion is published.
As part of this, I have added a new endpoint to retrieve an environment feature version, which will also include the uuid of the previous version. This will allow the FE to generate a page dedicated to a version and show the diff against the previous version. This can then be linked to from the audit log to achieve the same behaviour that we had previously.
How did you test this code?
Added new unit tests.