feat(core): add structured trade parameters, results, and contract statistics to TestArbitrage.sol
#145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new structs and corresponding NatSpec documentation into the
TestArbitrage
contract to improve clarity, maintainability, and analytical capabilities of the arbitrage testing framework. These additions allow for more structured trade execution, result tracking, and performance monitoring.Changes
Added Structs
TradeParams
: encapsulates all configurable parameters for executing arbitrage (router paths, token paths, fee, slippage, deadlines, etc.).TradeResult
: captures detailed outcome metrics (success, flash loan amount, profit, gas used, timestamp, tokens).ContractStats
: tracks overall performance metrics (total trades, cumulative profit, total volume, average gas usage, last trade timestamp).Added NatSpec Documentation
Constructor Update
block.timestamp
.Codebase Metrics
Why This Change
Impact
Testing
stats.lastTradeTimestamp
.TradeParams
andTradeResult
.Next Steps
TradeParams
.TradeResult
for easier on-chain monitoring.ContractStats
during live simulations.