feat(core): add stats
and tradeHistory
state variables with NatSpec documentation to TestArbitrage.sol
#146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new state variables and a dedicated NatSpec section header into the
TestArbitrage
contract. These additions improve the transparency and accessibility of contract performance data while enabling detailed tracking of individual trades.Changes
Added Section Header
STATE VARIABLES
section for improved readability and code organization.Added State Variables
ContractStats public stats
:public
for direct external access.mapping(uint256 => TradeResult) public tradeHistory
:Added NatSpec Documentation
stats
andtradeHistory
.Formatting
forge fmt
to ensure style consistency.Codebase Metrics
Why This Change
stats
) and detailed trade outcomes (tradeHistory
).Impact
Testing
stats
andtradeHistory
are accessible aspublic
.tradeHistory
storage and stats updates after trades.Next Steps
stats
andtradeHistory
update correctly after executions.