feat: Add profitRecipient
address and ConfigurationUpdated
event for flexible profit distribution and governance transparency
#150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR introduces two significant improvements to
TestArbitrage.sol
:profitRecipient
address to allow profits to be directed to an account different from the contract owner.ConfigurationUpdated
event to standardize and improve transparency for any future configuration changes.Both features enhance flexibility and governance while maintaining clear auditing capabilities.
Changes
Profit Recipient
address public profitRecipient;
ConfigurationUpdated Event
parameter
: Name of the updated parameter.oldValue
: The previous value.newValue
: The updated value.changedBy
: Address that executed the update.Formatting
forge fmt
to keep code style consistent.Rationale
Profit Flexibility
Owners may want to separate governance (ownership) from financial beneficiaries (profit recipients). This allows scenarios where a DAO governs the contract but profits flow to a treasury wallet.
Governance Transparency
Clear event logs for parameter updates improve traceability and accountability, aiding both testing and production environments.
Impact
Next Steps
profitRecipient
with appropriate access control.ConfigurationUpdated
when profit recipient or other parameters change.ConfigurationUpdated
event emission.