Use spawn(), not execFile().
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: turn a bunch of Promise functions into async's. Previously, onError was unused.
…able-promises refactor: change some confusing Promise() functions into clearer async's.
Create a new parameter, `noshell`, which is negated to get the
value of the `shell` parameter given to `spawn()`.
Make spawning use `spawn(file, args, {'shell': false})` instead of
`execFile(file, args)`. `spawn` gives a stdio stream, whereas `execFile`
waits for the subprocess to exit, and then gives all the output.
Also don't escape args for a shell when we don't use a shell.
Pull Request Test Coverage Report for Build 2471651780
💛 - Coveralls |
|
Come to think of it, maybe |
|
Wrapping in quotes is a requirement - Behaviour, particularlly in native Flash player executables, differs depending on spacing in URLs. |
|
Unsure what you mean by that. The change with the quotes only affects the filename, not the arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
execFile(file, args)tospawn(file, args, {'shell':false}).Most of the justification for switching may be found here.
Because
execFile()isn't used anymore, I changed the name of theexecFileparameter tonoshell, and eliminated the redundantshellparameter (except in some ManagedChildProcess internals whereshellmakes more sense).Also, fix
createCommand()on Mac and Linux (#333). Previously, it would surround the filename in quotes, regardless of theexecFile(nownoshell) argument.