Skip to content

peerDependency causes issues #74

@pburtchaell

Description

@pburtchaell

Does this component really depend on Does react-canvas really depend on React v0.13.0-beta.1? When installed with other commonly used React modules from npm (react-router, react-hot-loader, etc.) this causes npm to be unable to resolve which version of React to use.

For example:

npm ERR! peerinvalid The package react does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer react-router@0.11.6 wants react@0.12.x
npm ERR! peerinvalid Peer react-canvas@0.0.1 wants react@^0.13.0-beta.1
npm ERR! peerinvalid Peer react-hot-loader@1.1.5 wants react@>=0.11.0 || >=0.13.0-beta.1

If react-canvas actually does depend on the beta version of React and the beta version only, then I would update the README to let users know this. Otherwise, I would suggest updating the value of the peerDependency property to be >=0.11.x || 0.13.0-beta.1 in order to enable npm to properly resolve React.

If you are open to this change, I can make a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions