Don't move window when dragging a split. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks a bunch 👍 I wonder why I didn't spot this BIG issue before... I've just tested the fix and it seems to work (will update main.html soon: updated). As far as the Windows build is concerned, I'd like to make it work out of the box, but I'm on Linux, so without any feedback, I can't do much... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't move window when dragging a split. You can see this bug in the
main.htmlHTML demo: click theImGui Dockbutton, then drag the horizontal splitter vertically in the resulting window. I couldn't get the demo code building in Windows, but this fix did fix it in my test code...(Because the splitter ends up behind everything else, the hovered ID needs to be updated manually. The splitter's invisible button's call to
ImGui::ItemHoverableends up bailing out early from theg.HoveredWindow != g.CurrentWindowcheck, so the hovered ID is never updated there. If there's no hovered ID by the time ofImGui::EndFrame, there appears to be no widget under the cursor, and dragging the mouse may then move the window.)