Skip to content

Explorer default enter keypress action: open in file manager option #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 29, 2023
Merged

Explorer default enter keypress action: open in file manager option #2004

merged 8 commits into from
Mar 29, 2023

Conversation

VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Mar 24, 2023 •
edited by jjw24
Loading

Changes

Tests

  • Open in default file manager option works.
  • Opening a zip file result in Flow triggers the associated program rather than Windows explorer.
  • Ctrl+Enter opens the parent folder correctly.
  • Ctrl+Shift+Enter to open folder result in default file manager.

TODO: Update docs

@VictoriousRaptor VictoriousRaptor linked an issue Mar 24, 2023 that may be closed by this pull request
BUG: Explorer's Ctrl+Enter does not open containing folder + Wizard's description #1872
Closed
1 task
@VictoriousRaptor
Fix path search logic
9db13fd 
open folder in file manager when path search is disabled
@VictoriousRaptor VictoriousRaptor self-assigned this Mar 24, 2023
@VictoriousRaptor VictoriousRaptor mentioned this pull request Mar 25, 2023
Merged
@jjw24 jjw24 added review in progress Indicates that a review is in progress for this PR Explorer Plugin Issue or Enhancement Link to Explorer Plugin labels Mar 28, 2023
@jjw24 jjw24 added this to the 1.15.0 milestone Mar 28, 2023
jjw24
jjw24 reviewed Mar 28, 2023
View reviewed changes
@VictoriousRaptor VictoriousRaptor changed the title Explorer default action Explorer default action: open in file manager Mar 29, 2023
@VictoriousRaptor VictoriousRaptor requested a review from jjw24 March 29, 2023 07:27
@jjw24 jjw24 added enhancement New feature or request and removed review in progress Indicates that a review is in progress for this PR labels Mar 29, 2023
@jjw24 jjw24 changed the title Explorer default action: open in file manager Explorer default enter keypress action: open in file manager option Mar 29, 2023
jjw24
jjw24 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 merged commit 77e966e into Flow-Launcher:dev Mar 29, 2023
@VictoriousRaptor VictoriousRaptor deleted the ExplorerDefaultAction branch March 29, 2023 16:14
VictoriousRaptor added a commit that referenced this pull request Mar 30, 2023
@VictoriousRaptor
Fix wrong variable name in #2004 (#2014)
19ba8e4 
* Fix wrong variable name

* Fix typo
@VictoriousRaptor VictoriousRaptor mentioned this pull request Apr 19, 2023
Closed
@jjw24 jjw24 mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

@taooceros taooceros Awaiting requested review from taooceros

Assignees

@VictoriousRaptor VictoriousRaptor

Labels
enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin
Projects
Work In Progress
Archived in project
Milestone
1.15.0
2 participants
@VictoriousRaptor @jjw24