Skip to content

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Jan 6, 2021

fix #273, also link to the image fuzzy for #212

@taooceros
Copy link
Member Author

I take a try on both svg and the high quality bitmap scale mode, both displays result similarly. However, both contains a few fuzzy part (not significant and much better than current image). I believe that's due to that we only provide a 48*48 place for displaying the image.

@taooceros taooceros requested review from JohnTheGr8 and jjw24 and removed request for jjw24 January 6, 2021 02:37
@jjw24
Copy link
Member

jjw24 commented Jan 6, 2021

now that we switched to svg, should we archive mainsearch.png into the 'doc' folder only for future reference instead?

@jjw24 jjw24 added the enhancement New feature or request label Jan 6, 2021
@taooceros
Copy link
Member Author

now that we switched to svg, should we archive mainsearch.png into the 'doc' folder only for future reference instead?

If we do deside to switch to svg, we can archive the png one, since it is only used here.

@taooceros
Copy link
Member Author

now that we switched to svg, should we archive mainsearch.png into the 'doc' folder only for future reference instead?

Does svg solve your icon blurry issue? I am not sure because in my computer, the icon looks not that bad. @jjw24

BTW, seems that the svg control makes an issue displaying in the theme tab in setting window.
image

@taooceros
Copy link
Member Author

now that we switched to svg, should we archive mainsearch.png into the 'doc' folder only for future reference instead?

Does svg solve your icon blurry issue? I am not sure because in my computer, the icon looks not that bad. @jjw24

BTW, seems that the svg control makes an issue displaying in the theme tab in setting window.

solve it....I originally think it is a wrapped mainwindow, but actually they are separately🤣

@taooceros taooceros requested a review from jjw24 January 6, 2021 07:53
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more changes please per comment before going ahead

@taooceros taooceros requested a review from jjw24 January 6, 2021 08:53
@jjw24
Copy link
Member

jjw24 commented Jan 6, 2021

lets keep mainsearch.png around for now for reference

Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change, thank you!

@taooceros
Copy link
Member Author

Thank you for reviewing!

@jjw24 jjw24 merged commit fb18869 into Flow-Launcher:dev Jan 6, 2021
@taooceros taooceros deleted the ImageQuality branch January 9, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better magnifying glass icon on query window

2 participants