-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lowercasing emails before use #30
Milestone
Comments
Yes I have issue for this on the API repo.
But still, client should always lowercase it before sending. In fact, the
client should always lowercase all emails before saving them into DB or
processing them in any way. That's what I do in the chrome extension and
doing that helped me fix a lot of nasty bugs.
On Jun 2, 2017 6:31 AM, "Den" <notifications@github.com> wrote:
Assigned #30
<#30> to
@tomholub <https://github.com/tomholub>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGA8kZmdlqrQiUG4uzMpJuSJ6pWKTq3sks5sAACMgaJpZM4NuOAO>
.
|
OK. I will do the checks in my code and close this task. |
I checked my code. All is well. |
Reopening this as when typing someone's email address, the beginning of the email was capitalized. It stayed that way & the pubkey could not be found as a result. The email should be lowercased while I'm typing it, or when I'm done typing it, so that it's always lowercased before further processing. |
tomholub
changed the title
https://attester.cryptup.io/lookup/email email case sensitive
lowercasing emails before use
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I used https://attester.cryptup.io/lookup/email, I saw that this API is case sensitive for email parameter.
Do I have to manually check that I send the parameter in lowercase? Or maybe it's better for API to solve this issue? As far as I know, it does not matter how to write email address. (For example "denbond7@gmail.com" = "DeNBoND@GmAIL.cOm")
The text was updated successfully, but these errors were encountered: