-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Instances: Remote Instances Tab #1795
Conversation
@knolleary Would appreciate a round a of extra click testing as part of the review. These tables contains a lot of not immediately visible functionality (set snapshots/create/edit/delete device etc...). If tests are green, and PR is reviewed, please merge to |
UI Tests failing. Will try to figure out what's up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some wording tweaks along the way.
Still need to figure out the UX test failures.
frontend/src/pages/instance/Snapshots/dialogs/SnapshotAssignDialog.vue
Outdated
Show resolved
Hide resolved
frontend/src/pages/instance/Snapshots/dialogs/SnapshotCreateDialog.vue
Outdated
Show resolved
Hide resolved
I cannot figure out the test failures. I'm not so familiar with the cypress tests or how they are intended to work. A couple failures are when loading an Project Overview page, failing on |
I'm going to merge some of the proposed tweaks to the language... but don't feel like I can merge with the test failing. I don't have bandwidth today to figure out the tests. Will need to pickup on Monday with @Pezmc |
@knolleary Tests fixed and shored up a bit, PR ready for re-review. |
frontend/src/pages/instance/Snapshots/dialogs/SnapshotAssignDialog.vue
Outdated
Show resolved
Hide resolved
This reverts commit 9258172.
Description
Moves the devices tab down into instances and simplifies the remote instances tab for applications to solely list the remote instances, with a link to the instances remote instances page.
Team Devices
Application Overview - with remote instances list
Instance - Remote Instances List
Related Issue(s)
Completes #1718
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label