Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Instances: Remote Instances Tab #1795

Merged
merged 14 commits into from
Mar 13, 2023
Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 10, 2023

Description

Moves the devices tab down into instances and simplifies the remote instances tab for applications to solely list the remote instances, with a link to the instances remote instances page.

Team Devices

Screenshot 2023-03-10 at 12 58 10

Application Overview - with remote instances list

Screenshot 2023-03-10 at 12 57 40

Instance - Remote Instances List

Screenshot 2023-03-10 at 12 57 33

Related Issue(s)

Completes #1718

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary March 10, 2023 12:01
@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 10, 2023

@knolleary Would appreciate a round a of extra click testing as part of the review.

These tables contains a lot of not immediately visible functionality (set snapshots/create/edit/delete device etc...).

If tests are green, and PR is reviewed, please merge to main and trigger staging deploy.

@knolleary
Copy link
Member

UI Tests failing. Will try to figure out what's up.

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording tweaks along the way.

Still need to figure out the UX test failures.

frontend/src/pages/team/Overview.vue Outdated Show resolved Hide resolved
frontend/src/pages/instance/index.vue Show resolved Hide resolved
frontend/src/pages/device/Overview.vue Outdated Show resolved Hide resolved
frontend/src/pages/instance/Snapshots/index.vue Outdated Show resolved Hide resolved
frontend/src/pages/project/DevicesBrowser.vue Outdated Show resolved Hide resolved
frontend/src/pages/project/DevicesBrowser.vue Outdated Show resolved Hide resolved
frontend/src/pages/project/DevicesBrowser.vue Outdated Show resolved Hide resolved
frontend/src/pages/project/Overview.vue Outdated Show resolved Hide resolved
@knolleary
Copy link
Member

I cannot figure out the test failures. I'm not so familiar with the cypress tests or how they are intended to work.

A couple failures are when loading an Project Overview page, failing on cy.wait('@getProjectDevices'). I believe that is defined as cy.intercept('GET', '/api/*/projects/*/devices').as('getProjectDevices')
But in the logs I can see calls to get a matching url.. which is presumably what the test is waiting for, but not seeing.

@knolleary
Copy link
Member

I'm going to merge some of the proposed tweaks to the language... but don't feel like I can merge with the test failing. I don't have bandwidth today to figure out the tests. Will need to pickup on Monday with @Pezmc

@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 13, 2023

@knolleary Tests fixed and shored up a bit, PR ready for re-review.

@knolleary knolleary merged commit d006e27 into main Mar 13, 2023
@knolleary knolleary deleted the feat-1718-devices-tab branch March 13, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants