Multiple Instances: Polish Tasks

[Pezmc]

Description

• Fixes UI of application name when deleting
• Prevents opening editor also navigating to another page
• Adds application to devices table

Related Issue(s)

Fixes #1950, part of #1914

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on flowforge/helm to update ConfigMap Template
  • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

• Backport needed? -> add the backport label
• Includes a DB migration? -> add the area:migration label

[joepavitt]

Awaiting tests to run before merging, but all looks good, thanks Pez.

[Steve-Mcl]

Assuming the "Application" and "Instance" column entries are clickable, should we not indicate these are hyperlinks (blue text perhaps)?

At first glance, I have no idea I can click these.

[joepavitt]

Assuming the "Application" and "Instance" column entries are clickable, should we not indicate these are hyperlinks (blue text perhaps)?

Appreciate the feedback Steve, having every application/instance name as blue text would be a little overwhelming with the highlighting of clickable things imo, but I do agree with your point. I don't want to rush in something for tomorrow, so will have a think about alternatives

[Steve-Mcl]

Upon driving latest staging env, I note that it is now a wee bit more difficult to delete an instance,

Prior to these changes, the application-name-to-delete was on its own line and could simply be triple clicked to highlight the full thing.

Now I have to highlight with mouse :( (and waste many valuable milliseconds!)

Before:

After:

---

its the little things 😄

[Pezmc]

I think one could argue that it being slightly inconvenient is part of the "are you sure" design, and a "normal user" isn't going to be deleting a bunch of instances at once. Perhaps we could make the text click to copy though.

[Steve-Mcl]

click to copy

Even betterer