Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Instance and application names in delete popup easily selectable #2291

Merged
merged 2 commits into from
Jun 16, 2023
Merged

make Instance and application names in delete popup easily selectable #2291

merged 2 commits into from
Jun 16, 2023

Conversation

sumitshinde-84
Copy link
Contributor

@sumitshinde-84 sumitshinde-84 commented Jun 15, 2023

Description

i have used flex on parent instead of using block because if we use only block it will select easily instance and application name but code block will start from new line like below


flowforge2

and popup Ui will not broke if we use flex like below

flowforge3

Related Issue(s)

closes #2267

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@sumitshinde-84 sumitshinde-84 changed the title Developement make Instance and application names in delete popup easily selectable Jun 15, 2023
@Pezmc
Copy link
Contributor

Pezmc commented Jun 15, 2023

Hi @sumitshinde-84, thank you for your contribution! I can see click testing locally that the experience is slightly improved, but on my machine it requires a tripple click, I'm going to tag someone to check if that's what they were looking for.

@Steve-Mcl Was the original request to enable double clicking to select instance name? This change appears to allow triple clicking (at least checking on macOS), can you see how it behaves locally for you?

Screen.Recording.2023-06-15.at.23.13.24.mov

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Jun 15, 2023

@Pezmc triple click is what I used to do and #1962 removed this.

I had pointed it out here: #1962 (comment) (but it was already merged and I was not the reviewer.

You did suggest (in the next comment) that you might add click to copy - which would be sweet but triple click is something I am personally very familiar with so I'm fine either way Pez.

Ps, I did try this change earlier (I was intrigued as to why it worked) and it did work, but I did notice some very minor text alignment / selection overlap going on (possibly down to our styles? x margin tweak on <code> elements needed?)

@hardillb
Copy link
Contributor

Tripple click (for names with a -) double for names without works for me.

@hardillb hardillb merged commit 57d884c into FlowFuse:main Jun 16, 2023
@sumitshinde-84 sumitshinde-84 deleted the Developement branch June 16, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance names in delete popup not easily selectable
4 participants