Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename target to NextStageId and NextStage for clarity #2189

Merged
merged 2 commits into from
May 26, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented May 26, 2023

Description

Renames PipelineStage.target to PipelineStage.NextStageId for developer quality of life.

Related Issue(s)

Fixes #2165

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary May 26, 2023 14:43
@Pezmc
Copy link
Contributor Author

Pezmc commented May 26, 2023

I think the tests might fail, but I don't have time to sit and wait, will fix up any renaming required in the texts if I get time today! Else next week.

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the fence about NextStageId vs nextStageId. I can see why either would be valid and consistent with what we already have depending on how you look at it. Don't feel strongly enough to push it to be lower-cased - just noting it.

@Pezmc
Copy link
Contributor Author

Pezmc commented May 26, 2023

Solely uppercase because that seems to be the standard in FlowForge database. I prefer nextStageId.

@Pezmc Pezmc merged commit 441aeb8 into 2075-application-pipelines May 26, 2023
@Pezmc Pezmc deleted the 2124-rename-pipeline-target branch May 26, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants