Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Mass minor upgrade of all packages #2193

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented May 30, 2023

Minor upgrade of all packages.

Of note:

  • Minor version only, if upstream packages are following semver correctly this should be backward compatible
  • Due to lack of package lock, in most cases, we're likely running these versions already

@Pezmc
Copy link
Contributor Author

Pezmc commented Jun 14, 2023

Rebased onto the latest copy of main

@Pezmc Pezmc marked this pull request as ready for review June 15, 2023 08:28
@Pezmc
Copy link
Contributor Author

Pezmc commented Jun 15, 2023

@knolleary Given the tests have passed, some rudimentary click testing locally of areas of the codebase that these packages are used hasn't brought up issues, that the next release isn't for a few weeks giving us plenty of time to test on staging, and we can trust most packages to stick to sever (minor version bump only); this PR is almost as "safe" as it will get; and I propose we merge this PR as is.

Once merged and deployed, we can highlight to the team at the dev meeting to keep an eye out for any odd behaviour on staging or locally in the mean time to get extra QA.

@Pezmc Pezmc requested a review from knolleary June 15, 2023 08:30
@knolleary knolleary merged commit 9a26f5c into main Jun 15, 2023
@knolleary knolleary deleted the chore-experiment-upgrade branch June 15, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants