Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ui-components & utilise new ff-theme-dark on signup/login #2425

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Update ui-components & utilise new ff-theme-dark on signup/login #2425

merged 1 commit into from
Jul 11, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Jul 6, 2023 •
edited
Loading

Description

  • In fixing Accept T&C checkbox on signup page broken #2419 noticed a more fundamental problem that had been bugging me for a while with ui-components in how it deals with dark theming (detailed here).
  • These issues were meaning we had to write our own dark-them logic in /flowforge in some cases (due to slightly different bg colouring), which is nonsensical
  • 0.7.0 of ui-components fixes that, and introduces a new ff-theme-dark class which will inherit the correct component-by-component CSS, and consequently fixes Accept T&C checkbox on signup page broken #2419

Examples:

Screenshot 2023-07-06 at 15 21 16

Related Issue(s)

Fixes #2419

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
    • CSS only changes

Labels

  • Backport needed? -> add the backport label

@joepavitt joepavitt requested a review from knolleary July 6, 2023 14:16
@knolleary knolleary merged commit 3058280 into main Jul 11, 2023
@knolleary knolleary deleted the ui-components-theming branch July 11, 2023 22:16
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
3 tasks
knolleary added a commit that referenced this pull request Jul 11, 2023
@knolleary
Merge pull request #2470 from flowforge/backport-2425
09c0826 
Update ui-components & utilise new ff-theme-dark on signup/login (backport #2425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept T&C checkbox on signup page broken
2 participants
@joepavitt @knolleary