Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui-components & utilise new ff-theme-dark on signup/login (backport #2425) #2470

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

github-actions[bot]
Copy link

Backport of #2425


Description

  • In fixing Accept T&C checkbox on signup page broken #2419 noticed a more fundamental problem that had been bugging me for a while with ui-components in how it deals with dark theming (detailed here).
  • These issues were meaning we had to write our own dark-them logic in /flowforge in some cases (due to slightly different bg colouring), which is nonsensical
  • 0.7.0 of ui-components fixes that, and introduces a new ff-theme-dark class which will inherit the correct component-by-component CSS, and consequently fixes Accept T&C checkbox on signup page broken #2419

Examples:

<img width="499" alt="Screenshot 2023-07-06 at 15 21 16" src="https://github.com/flowforge/flowforge/assets/99246719/d84c1e8a-3aea-485c-ac2c-9e43433fd190\">

Related Issue(s)

Fixes #2419

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • CSS only changes

Labels

  • Backport needed? -> add the backport label

@knolleary knolleary merged commit 09c0826 into maintenance Jul 11, 2023
@knolleary knolleary deleted the backport-2425 branch July 11, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants