Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for empty values in logging stream #2479

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add checks for empty values in logging stream #2479

merged 1 commit into from
Jul 13, 2023

Conversation

hardillb
Copy link
Contributor

Fix for crash in production

Description

It looks like the new logging code is hitting a problem with missing fields



2023-07-13 09:35:47 | {"log":"    at Object.res (/usr/src/forge/app/node_modules/@flowforge/flowforge/forge/forge.js:61:48)\n","stream":"stderr","time":"2023-07-13T08:35:47.706549905Z"}
2023-07-13 09:35:47 | {"log":"TypeError: Cannot read properties of undefined (reading 'raw')\n","stream":"stderr","time":"2023-07-13T08:35:47.706546145Z"}
2023-07-13 09:35:47 | {"log":"\n","stream":"stderr","time":"2023-07-13T08:35:47.706542565Z"}
2023-07-13 09:35:47 | {"log":"                                               ^\n","stream":"stderr","time":"2023-07-13T08:35:47.706538427Z"}
2023-07-13 09:35:47 | {"log":"                            url: reply.request.raw.url,\n","stream":"stderr","time":"2023-07-13T08:35:47.706534265Z"}
2023-07-13 09:35:47 | {"log":"/usr/src/forge/app/node_modules/@flowforge/flowforge/forge/forge.js:61\n","stream":"stderr","time":"2023-07-13T08:35:47.706520639Z"}


Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.10 milestone Jul 13, 2023
@hardillb hardillb requested a review from knolleary July 13, 2023 08:51
@hardillb hardillb self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2479 (5bbb90d) into main (3058280) will increase coverage by 33.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2479       +/-   ##
===========================================
+ Coverage   38.87%   72.32%   +33.45%     
===========================================
  Files         489      224      -265     
  Lines       17078     8817     -8261     
  Branches     3955     1811     -2144     
===========================================
- Hits         6639     6377      -262     
+ Misses      10439     2440     -7999     
Flag Coverage Δ
backend 72.32% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
forge/forge.js 90.00% <ø> (ø)

... and 346 files with indirect coverage changes

@knolleary knolleary merged commit c2ac613 into main Jul 13, 2023
@knolleary knolleary deleted the log-fix branch July 13, 2023 09:05
knolleary added a commit that referenced this pull request Jul 13, 2023
Add checks for empty values in logging stream (backport #2479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants