Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for empty values in logging stream (backport #2479) #2480

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

github-actions[bot]
Copy link

Backport of #2479


Fix for crash in production

Description

It looks like the new logging code is hitting a problem with missing fields



2023-07-13 09:35:47 | {\"log\":\" at Object.res (/usr/src/forge/app/node_modules/@flowforge/flowforge/forge/forge.js:61:48)\\n\",\"stream\":\"stderr\",\"time\":\"2023-07-13T08:35:47.706549905Z\"}
2023-07-13 09:35:47 | {\"log\":\"TypeError: Cannot read properties of undefined (reading 'raw')\\n\",\"stream\":\"stderr\",\"time\":\"2023-07-13T08:35:47.706546145Z\"}
2023-07-13 09:35:47 | {\"log\":\"\\n\",\"stream\":\"stderr\",\"time\":\"2023-07-13T08:35:47.706542565Z\"}
2023-07-13 09:35:47 | {\"log\":\" ^\\n\",\"stream\":\"stderr\",\"time\":\"2023-07-13T08:35:47.706538427Z\"}
2023-07-13 09:35:47 | {\"log\":\" url: reply.request.raw.url,\\n\",\"stream\":\"stderr\",\"time\":\"2023-07-13T08:35:47.706534265Z\"}
2023-07-13 09:35:47 | {\"log\":\"/usr/src/forge/app/node_modules/@flowforge/flowforge/forge/forge.js:61\\n\",\"stream\":\"stderr\",\"time\":\"2023-07-13T08:35:47.706520639Z\"}


Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
  • Changes flowforge.yml?
  • Issue/PR raised on flowforge/helm to update ConfigMap Template
  • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary knolleary merged commit 11fed67 into maintenance Jul 13, 2023
@knolleary knolleary deleted the backport-2479 branch July 13, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants